Muli Salem has posted comments on this change.

Change subject: core: AddVmInterface Calls PlugUnplugCommand (#850854)
......................................................................


Patch Set 2: No score

(1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 69: 
Line 70:         TransactionSupport.executeInNewTransaction(new 
TransactionMethod<Void>() {
Line 71:             @Override
Line 72:             public Void runInTransaction() {
Line 73:                 addInterfaceToDb(getParameters().getInterface());
As we discussed, is not necessary.
Line 74:                 addInterfaceDeviceToDb();
Line 75:                 getCompensationContext().stateChanged();
Line 76:                 return null;
Line 77:             }


--
To view, visit http://gerrit.ovirt.org/7542
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc4636c8003ea3fc170a13be96a3efb9dc8cca24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to