Moti Asayag has posted comments on this change. Change subject: core: added missing logging + refactoring ......................................................................
Patch Set 14: > (1 comment) The easiest approach is to abandon the patches, especially if we end up with a broken audit log director for audit log type which has no messages. This tend to happen when we've deprecated the AuditLogType and remove all of its usages and the message as well, however we left the AuditLogType since it has a numeric value which is stored in the db (event_log table) and is being referred by code (i.e. from the notification service). So you patches make the AuditLogDirector mode maintainable - but if at the end the tests are failing due to missing inputs - we can't merge it. Can the test produce the list of audit-log-types which misses the an entry in the AuditLogMessages.properties file ? If it is doable and you wish to put more effort, you can create the list and send it to @devel. If you got exhausted - feel free to abandon them. -- To view, visit https://gerrit.ovirt.org/29244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
