Martin Mucha has posted comments on this change. Change subject: core: added missing logging + refactoring ......................................................................
Patch Set 16: I think it's not true. *Currently* we end up with broken audit log. Replacing null with "", will cause exactly same behavior, only with sane code. But without action it will remain broken; I do not observe localizing "VDS_HIGH_NETWORK_USE" as "" as a valid code. Yes, referenced change *can* produce list of missing translations. I and at least one more person sent it more than once on mailing list; especially on devel mailing list you can find it, so sending it again is probably pointless. It's not about exhaustion, but frustration. You wanted that test. I'm ok with ruining company money in vain and abandoning mine patches, since I don't have any other choice. Do you want have this merged and are you able to force others to provide translations at a same time? Currently missing translations are: java.lang.AssertionError: translation key="VDS_HIGH_NETWORK_USE" is not present in resource bundle "bundles/AuditLogMessages" java.lang.AssertionError: translation key="USER_FAILED_REMOVE_VM" is not present in resource bundle "bundles/AuditLogMessages" java.lang.AssertionError: translation key="USER_RUN_UNLOCK_ENTITY_SCRIPT" is not present in resource bundle "bundles/AuditLogMessages" java.lang.AssertionError: translation key="VDS_NETWORK_MTU_DIFFER_FROM_LOGICAL_NETWORK" is not present in resource bundle "bundles/AuditLogMessages" java.lang.AssertionError: translation key="VDS_NETWORK_MTU_DIFFER_FROM_LOGICAL_NETWORK" is not present in resource bundle "bundles/AuditLogMessages" java.lang.AssertionError: translation key="STORAGE_ACTIVATE_ASYNC" is not present in resource bundle "bundles/AuditLogMessages" java.lang.AssertionError: translation key="STORAGE_ACTIVATE_ASYNC" is not present in resource bundle "bundles/AuditLogMessages" -- To view, visit https://gerrit.ovirt.org/29244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
