Greg Padgett has posted comments on this change. Change subject: engine : Call doPolling on parent commands when children have converged ......................................................................
Patch Set 1: In most situations I think this would simplify things. However, I think it's taking away one of my favorite parts of CoCo: the ability for parent and children commands to both run/monitor/change independently of one another. I envision some scenarios where we might want to exploit this. For example, maybe we want to allow parallel Live Merge, up to N merges at a time. Today, we could have the parent track the number of concurrent merges, and if one child finished it would start another. This type of system wouldn't be possible unless a parent's doPolling() method was called while children were running. I don't know if it's aligned with the design goals of CoCo, but if we're trying to optimize the execution, can retaining the old behavior at least be an option for parents when starting a child? -- To view, visit https://gerrit.ovirt.org/38356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85b6abd962a7b2e145177ea0fbdf37e8261b553 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
