Liron Aravot has posted comments on this change. Change subject: engine : Call doPolling on parent commands when children have converged ......................................................................
Patch Set 1: I do agree that we need a way to not wait for all childs to end (an example would be that if one child fails, we can "signal" the others to stop) - but in some cases it might be useful (at least now). We do want the flexibility to have doPolling run every few seconds, but if we have child commands it's sometimes unnecessary and can hurt us in terms of scale. perhaps we can have the following options: 1. call doPolling only when child commands converge 2. call doPolling only when any child command change status (for example - to notify the other child commands to stop) 3. call doPolling every few seconds. options 1+2 should cover most of the cases, special cases could use option 3. what do you guys think? -- To view, visit https://gerrit.ovirt.org/38356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85b6abd962a7b2e145177ea0fbdf37e8261b553 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
