Moti Asayag has posted comments on this change. Change subject: engine: Block non-exclusive network configurations (#851134) ......................................................................
Patch Set 3: Looks good to me, approved (1 inline comment) Please fix minor typo in javadoc. Thanks for the extra tests. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java Line 256: return vlanId != null ? NetworkType.VLAN : vmNetwork ? NetworkType.VM : NetworkType.NON_VM; Line 257: } Line 258: Line 259: /** Line 260: * Make sure that if the given interface has a VM network on it then there is noting else on the interface, or if s/noting/nothing Line 261: * the given interface is a VLAN network, than there is no VM network on the interface.<br> Line 262: * Other combinations are either legal or illegal but are not a concern of this method. Line 263: * Line 264: * @param iface -- To view, visit http://gerrit.ovirt.org/7664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2712b6e6948de0881c56d519bbf82f7ecc7f6157 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
