Moti Asayag has posted comments on this change.

Change subject: engine: Block non-exclusive network configurations (#851134)
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
Line 259:     /**
Line 260:      * Make sure that if the given interface has a VM network on it 
then there is nothing else on the interface, or if
Line 261:      * the given interface is a VLAN network, than there is no VM 
network on the interface.<br>
Line 262:      * Other combinations are either legal or illegal but are not a 
concern of this method.
Line 263:      * 
please remove.
Line 264:      * @param iface
Line 265:      *            The interface to check.
Line 266:      * @param networkType
Line 267:      *            The type of the network.


--
To view, visit http://gerrit.ovirt.org/7664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2712b6e6948de0881c56d519bbf82f7ecc7f6157
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to