Dan Kenigsberg has posted comments on this change.
Change subject: engine: Send port mirroring when hot-plug NIC (#853709)
......................................................................
Patch Set 1: Fails
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java
Line 44: if (vmDevice.getBootOrder() > 0) {
Line 45: map.add("bootOrder",
String.valueOf(vmDevice.getBootOrder()));
Line 46: }
Line 47: if (nic.isPortMirroring()) {
Line 48: struct.add(VdsProperties.portMirroring,
Collections.singletonList(nic.getNetworkName()));
portMirroring should be an element of "map", just like "macAddr", not an
element of the containing "struct".
Line 49: }
Line 50: return map;
Line 51: }
Line 52:
--
To view, visit http://gerrit.ovirt.org/7672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ba6a47b4ab42bc2a07f106e51eb9a9fe6baba7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
