Moti Asayag has posted comments on this change.
Change subject: engine: Send port mirroring when hot-plug NIC (#853709)
......................................................................
Patch Set 1: No score
(2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java
Line 44: if (vmDevice.getBootOrder() > 0) {
Line 45: map.add("bootOrder",
String.valueOf(vmDevice.getBootOrder()));
Line 46: }
Line 47: if (nic.isPortMirroring()) {
Line 48: struct.add(VdsProperties.portMirroring,
Collections.singletonList(nic.getNetworkName()));
This is the snippet from run vm for defining port mirroring
if (vmInterface.isPortMirroring()) {
List<String> networks = new ArrayList<String>();
networks.add(vmInterface.getNetworkName());
struct.add(VdsProperties.portMirroring, networks);
}
The confusion is having 'struct' element in both code areas with different
meaning.
s/struct.add/map.add
Line 49: }
Line 50: return map;
Line 51: }
Line 52:
....................................................
Commit Message
Line 5: CommitDate: 2012-09-02 15:05:44 +0300
Line 6:
Line 7: engine: Send port mirroring when hot-plug NIC (#853709)
Line 8:
Line 9: https://bugzilla.redhat.com/853709
we're using a template defined on onfig/engine-commit-template.txt
with the following content:
start template:
<core | restapi | tools | history | engine | userportal | webadmin>: short
summary under 50 chars (#xxxxxx)
https://bugzilla.redhat.com/XXXXXX
Longer description using lines' length under 72 chars.
With multiple paragraphs if necessary.
end template:
Since no new template was submitted, the ovirt-engine patches will continue
using this template and the process of enforcing structure will be annoying.
Previous commit template change was abandoned
http://gerrit.ovirt.org/#/c/7101/3 and new one should be submitted once enough
votes will be given to the thread on arch mailing list.
Line 10:
Line 11: Port mirroring should be sent if it is set on the NIC in case we're hot
Line 12: plugging the NIC to the VM.
Line 13:
--
To view, visit http://gerrit.ovirt.org/7672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ba6a47b4ab42bc2a07f106e51eb9a9fe6baba7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
