Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Limiting max timeo/retrans nfs options (#839298) ......................................................................
webadmin: Limiting max timeo/retrans nfs options (#839298) https://bugzilla.redhat.com/839298 In nfs, per retransmission, timeout is increased by 'timeo' param up to the max value of 600 seconds. Typical timeout for nfs (over TCP) is between 1-10 minutes, This patch set max value of 6000 tenths seconds to the timeo option. If retrans option is not set, nfs tries each request 3 times, current limit set to 100. Change-Id: Ied1361fc327654d30818edb476414525bef3994e Signed-off-by: Asaf Shakarchi <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/7692/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java index 38851ea..13df52e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java @@ -27,6 +27,11 @@ @SuppressWarnings("unused") public class NfsStorageModel extends Model implements IStorageModel { + //retrans nfs option max value + private final static short RETRANS_MAX = 100; + //timeo nfs option max value + private final static short TIMEOUT_MAX = 6000; + public static EventDefinition PathChangedEventDefinition; private Event pathChangedEvent; @@ -165,11 +170,11 @@ }); getRetransmissions().ValidateEntity(new IValidation[] { - new IntegerValidation(0, Integer.MAX_VALUE) + new IntegerValidation(0, RETRANS_MAX) }); getTimeout().ValidateEntity(new IValidation[] { - new IntegerValidation(1, Integer.MAX_VALUE) + new IntegerValidation(1, TIMEOUT_MAX) }); return getPath().getIsValid() -- To view, visit http://gerrit.ovirt.org/7692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ied1361fc327654d30818edb476414525bef3994e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
