Ayal Baron has posted comments on this change.
Change subject: webadmin: Limiting max timeo/retrans nfs options (#839298)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
Line 27: @SuppressWarnings("unused")
Line 28: public class NfsStorageModel extends Model implements IStorageModel {
Line 29:
Line 30: //retrans nfs option max value
Line 31: private final static short RETRANS_MAX = 100;
this should be a *lot* higher.
Line 32: //timeo nfs option max value
Line 33: private final static short TIMEOUT_MAX = 6000;
Line 34:
Line 35: public static EventDefinition PathChangedEventDefinition;
Line 29:
Line 30: //retrans nfs option max value
Line 31: private final static short RETRANS_MAX = 100;
Line 32: //timeo nfs option max value
Line 33: private final static short TIMEOUT_MAX = 6000;
I'm assuming this is passed as is to vdsm. If so the number is in tenths of
seconds and should be 600 (max timeout is 60s)
Line 34:
Line 35: public static EventDefinition PathChangedEventDefinition;
Line 36: private Event pathChangedEvent;
Line 37:
--
To view, visit http://gerrit.ovirt.org/7692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied1361fc327654d30818edb476414525bef3994e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
