Allon Mureinik has posted comments on this change.

Change subject: engine, webadmin: Allow to specify disk error_policy in Web UI
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/38329/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskErrorPolicy.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskErrorPolicy.java:

Line 7: 
Line 8:     REPORT("report"),
Line 9:     ENOSPC("enospc"),
Line 10:     STOP("stop"),
Line 11:     IGNORE("ignore");
Based on the correspondence on this bug, I'd remove the IGNORE option.
Line 12: 
Line 13:     private String name;
Line 14:     private static Map<String, DiskErrorPolicy> mappings;
Line 15: 


-- 
To view, visit https://gerrit.ovirt.org/38329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4bed1019f94064b9800fda0fb17a6def46ab221
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to