Daniel Erez has posted comments on this change. Change subject: engine, webadmin: Allow to specify disk error_policy in Web UI ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38329/6/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java: Line 418: // Disk type (internal/external) selection panel is visible only when Line 419: // 'Attach disk' mode is enabled or new LunDisk creation is enabled Line 420: diskTypePanel.setVisible(isNewLunDiskEnabled); Line 421: externalDiskPanel.setVisible(isNewLunDiskEnabled && disk.getDiskStorageType().getEntity() == DiskStorageType.LUN); Line 422: diskErrorPolicyEditor.setVisible(disk.getDiskStorageType().getEntity() != DiskStorageType.LUN); the editor is bounded to diskErrorPolicy entity, so it's visibility should be altered through the model. See 'AbstractDiskModel -> diskStorageType_EntityChanged()'. Line 423: aliasEditor.setFocus(!isInVm); Line 424: } Line 425: Line 426: private void revealStorageView(final AbstractDiskModel diskModel) { -- To view, visit https://gerrit.ovirt.org/38329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4bed1019f94064b9800fda0fb17a6def46ab221 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
