Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Stop dwhd service on engine-upgrade (BZ#843495)
......................................................................


Patch Set 3: I would prefer that you didn't submit this

I don't think this is the task of this package to stop package that is 
dependent upon it.

The systemd should take care of the service dependency so that if ovirt-engine 
is stopped also the dwh...

Or... if you do want to keep dwh alive when ovirt-engine is stopped, then maybe 
better to install a hook for the upgrade in the dwh so it will stop it-self.

There is far too much dependencies already between the packages without clear 
interface.

--
To view, visit http://gerrit.ovirt.org/7691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea0d058f8bc9c43ee03be74dcb9d7ed815c0293
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to