Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Stop dwhd service on engine-upgrade (BZ#843495)
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 756: 
Line 757:         # check if update is relevant to db update
Line 758:         if isUpdateRelatedToDb(rhyum):
Line 759:             stopDbRelatedServices(etlService, notificationService)
Line 760:             
spaces.
Line 761:             # Update the db and restore its name back
Line 762:             runFunc([db.update], MSG_INFO_DB_UPDATE)
Line 763:             runFunc([[db.rename, basedefs.DB_NAME]], 
MSG_INFO_RESTORE_DB)
Line 764: 


Line 762:             runFunc([db.update], MSG_INFO_DB_UPDATE)
Line 763:             runFunc([[db.rename, basedefs.DB_NAME]], 
MSG_INFO_RESTORE_DB)
Line 764: 
Line 765:             # Bring up any services we shut down before db upgrade
Line 766:             startDbRelatedServices(etlService, notificationService, 
dwhService)
I thought we do not handle external services...
Line 767: 
Line 768:         # post install conf
Line 769:         runFunc(postFunc, MSG_INFO_RUN_POST)
Line 770: 


--
To view, visit http://gerrit.ovirt.org/7691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea0d058f8bc9c43ee03be74dcb9d7ed815c0293
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to