Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/38547/7/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 61: ): Line 62: self.services.state( Line 63: name=service, Line 64: state=False, Line 65: ) so we do not need to stop it, we can restart it as we do in packages. Line 66: Line 67: @plugin.event( Line 68: stage=plugin.Stages.STAGE_MISC, Line 69: condition=lambda self: self.environment[ Line 79: ca_cert=os.path.join( Line 80: odeploycons.FileLocations.VDSM_TRUST_STORE, Line 81: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 82: ), Line 83: fqdn=self.environment[odeploycons.VdsmEnv.ENGINE_HOST], you have full control over the variables at peer. so if you need fqdn you can set the fqdn at the environment, there is no reason to set it here. I do understand that the ca certificate should be here, but all the rest is not something that is host specific. Line 84: ) Line 85: for env_key in self.environment: Line 86: if env_key.startswith( Line 87: odeploycons.HostedEngineEnv.HOSTED_ENGINE_CONFIG_PREFIX https://gerrit.ovirt.org/#/c/38547/7/src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py File src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py: this is still pending. Line 1: # Line 2: # ovirt-host-deploy -- ovirt host deployer Line 3: # Copyright (C) 2015 Red Hat, Inc. Line 4: # -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
