Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/38547/5/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 96: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 97: ), Line 98: 'fqdn': self.environment[ Line 99: odeploycons.VdsmEnv.ENGINE_HOST Line 100: ], > this should be set explicitly by engine as well, it can be same as other in can you explain the kind of change you're suggesting? I've not understood it. Line 101: 'service_start_time': odeploycons.Const.HOSTED_ENGINE_START_TIME, Line 102: } Line 103: for env_key in self.environment: Line 104: if env_key.startswith( Line 113: for key, value in conf.iteritems(): Line 114: content += '{key}={value}\n'.format( Line 115: key=key, Line 116: value=value, Line 117: ) > I am unsure why you first put within a map then create the content. Done Line 118: Line 119: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 120: filetransaction.FileTransaction( Line 121: name=odeploycons.FileLocations.HOSTED_ENGINE_CONF, https://gerrit.ovirt.org/#/c/38547/5/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 49: @plugin.event( Line 50: stage=plugin.Stages.STAGE_INIT, Line 51: ) Line 52: def _init(self): Line 53: self.environment[odeploycons.HostedEngineEnv.ENABLE] = False > setdefault Done Line 54: Line 55: @plugin.event( Line 56: stage=plugin.Stages.STAGE_PACKAGES, Line 57: condition=lambda self: self.environment[ Line 64: @plugin.event( Line 65: stage=plugin.Stages.STAGE_CLOSEUP, Line 66: ) Line 67: def _closeup(self): Line 68: self.logger.info(_('Enabling and starting HA services')) > not sure this comment is required Done Line 69: for service in ( Line 70: odeploycons.Const.HA_AGENT_SERVICE, Line 71: odeploycons.Const.HA_BROCKER_SERVICE, Line 72: ): -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
