Sharad Mishra has posted comments on this change. Change subject: core: minor canDoActionMesage simplification ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Just a minor change to commit message .................................................... Commit Message Line 9: Adds an alternative call similar to the original addCanDoActionMessage Line 10: that always returns false, so callers in case of error found can simply Line 11: use Line 12: Line 13: return canDoActionError(VdcBllMessages.foo); change method name to failCanDoAction Line 14: Line 15: Change-Id: I863e1524a145ce815aa4214488292e13df465557 -- To view, visit http://gerrit.ovirt.org/7731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I863e1524a145ce815aa4214488292e13df465557 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
