Mike Kolesnik has posted comments on this change.
Change subject: core: minor canDoActionMesage simplification
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1303: * Add validation message and return false. See {@link
#addCanDoActionMessage(String)}
Line 1304: * @param message the message to add
Line 1305: * @return false always
Line 1306: */
Line 1307: protected final boolean failCanDoAction(VdcBllMessages message) {
Why not modify the existing addCanDoActionMessage(VdcBllMessages message)
method?
Line 1308:
getReturnValue().getCanDoActionMessages().add(message.name());
Line 1309: return false;
Line 1310: }
Line 1311:
--
To view, visit http://gerrit.ovirt.org/7510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf6bf9b94aab9dc97a0d68cfde99e8f34af2914c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
