Allon Mureinik has posted comments on this change.

Change subject: core: add toString method to VM and VDS
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

see inline - other than that looks fine

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 1228: 
Line 1229:     public void setAutoRecoverable(boolean autoRecoverable) {
Line 1230:         mVdsStatic.setAutoRecoverable(autoRecoverable);
Line 1231:     }
Line 1232: 
please add @Override
Line 1233:     public String toString() {
Line 1234:         return "VDS[" + (mVdsStatic == null ? "null" : 
mVdsStatic.gethost_name()) + "]";
Line 1235:     }


--
To view, visit http://gerrit.ovirt.org/7640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cd449b18c6187d00366e2c30d4288c909a9ef6a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to