Arik Hadas has posted comments on this change. Change subject: webadmin: cleanup in DisksAllocationModel ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/38374/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-03-08 10:50:49 +0200 Line 6: Line 7: webadmin: cleanup in DisksAllocationModel Line 8: Line 9: Rename DisksAllocationModel#isVolumeTypeAvailable to > the renaming is the other way around..:) Done Line 10: isVolumeFormatAvailable as it controls the volume type and not the Line 11: volume format. Line 12: Line 13: Change-Id: I1ed7e2b15cb38715b39250bab2ac65eb0caaa68a https://gerrit.ovirt.org/#/c/38374/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java: Line 127: return quotaEnforcementType; Line 128: } Line 129: Line 130: private boolean isVolumeTypeAvailable; Line 131: private boolean isVolumeFormatChangable; > while at it, should be renamed as well.. Done Line 132: private boolean isAliasChangable; Line 133: private boolean isSourceStorageDomainAvailable; Line 134: private boolean isSourceStorageDomainNameAvailable; Line 135: private boolean isWarningAvailable; -- To view, visit https://gerrit.ovirt.org/38374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ed7e2b15cb38715b39250bab2ac65eb0caaa68a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
