Arik Hadas has posted comments on this change. Change subject: webadmin: cleanup in DisksAllocationModel ......................................................................
Patch Set 3: (1 comment) Guys, let's stop finding more places to rename and focus on the places which are relevant for the rest of this chain https://gerrit.ovirt.org/#/c/38374/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java: Line 352: Line 353: public void setIsVolumeTypeChangable(boolean isVolumeTypeChangable) { Line 354: if (this.isVolumeTypeChangable != isVolumeTypeChangable) { Line 355: this.isVolumeTypeChangable = isVolumeTypeChangable; Line 356: onPropertyChanged(new PropertyChangedEventArgs("VolumeFormat")); //$NON-NLS-1$ > If you're at it and want to do it correctly then the property name should a Done Line 357: } Line 358: } Line 359: Line 360: public void setIsSourceStorageDomainAvailable(boolean isSourceStorageDomainAvailable) { -- To view, visit https://gerrit.ovirt.org/38374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ed7e2b15cb38715b39250bab2ac65eb0caaa68a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
