Tal Nisan has posted comments on this change.
Change subject: core: Added lock to VM when hot plugging/unplugging disks
(#844440)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 238: true, true, disksList);
Line 239: }
Line 240: return result;
Line 241: }
Line 242:
Cause in case that the action failed before the can do part (In the lock aquire
part for instance), the message parameters are not set and you see the unset
variables in the can do action, so we need to set them in advance in this
method like the command convention
Line 243: @Override
Line 244: protected void setActionMessageParameters() {
Line 245: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__CREATE);
Line 246: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__SNAPSHOT);
--
To view, visit http://gerrit.ovirt.org/7805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ec6996b265851c7c691e1a4e68cba246df322a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
