Michael Kublin has posted comments on this change.
Change subject: core: Added lock to VM when hot plugging/unplugging disks
(#844440)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 15: import org.ovirt.engine.core.dal.VdcBllMessages;
Line 16: import org.ovirt.engine.core.utils.transaction.TransactionMethod;
Line 17: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 18:
Line 19: @NonTransactiveCommandAttribute
why not use annotattion?
Line 20: public class HotPlugDiskToVmCommand<T extends
HotPlugDiskToVmParameters> extends AbstractDiskVmCommand<T> {
Line 21:
Line 22: private static final long serialVersionUID = 2022232044279588022L;
Line 23:
--
To view, visit http://gerrit.ovirt.org/7805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ec6996b265851c7c691e1a4e68cba246df322a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
