Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 14: (3 comments) https://gerrit.ovirt.org/#/c/38547/14/ovirt-host-deploy-offline.spec.in File ovirt-host-deploy-offline.spec.in: Line 36: Requires: tar Line 37: Requires: tuned Line 38: Requires: util-linux Line 39: Requires: ovirt-hosted-engine-ha Line 40: Requires: ovirt-hosted-engine-setup > doesn't one pulls the other? Need to discuss this with some people but I think it's in the plan. Otherwise I'll change it to be required only on x86_64. Line 41: Requires: vdsm Line 42: Requires: vdsm-cli Line 43: %ifarch %{ix86} x86_64 Line 44: Requires: dmidecode https://gerrit.ovirt.org/#/c/38547/14/src/plugins/ovirt-host-deploy/core/offlinepackager.py File src/plugins/ovirt-host-deploy/core/offlinepackager.py: Line 69: 'release': '1', Line 70: 'epoch': '0', Line 71: 'arch': 'noarch', Line 72: }, Line 73: ] > you do not need this as you do not query these packages, just install. I'll remove Line 74: elif tuple(patterns) == ('vdsm',): Line 75: return [ Line 76: { Line 77: 'operation': 'installed', https://gerrit.ovirt.org/#/c/38547/14/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 59: ], Line 60: ) Line 61: def _packages(self): Line 62: self.packager.installUpdate(('ovirt-hosted-engine-ha',)) Line 63: self.packager.installUpdate(('ovirt-hosted-engine-setup',)) > why do we need both? doesn't one install the other? what if only ha is updated? setup is requiring it but AFAIK installUpdate won't update its dependencies. Line 64: Line 65: @plugin.event( Line 66: stage=plugin.Stages.STAGE_CLOSEUP, Line 67: ) -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
