Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/38547/14/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 59: ], Line 60: ) Line 61: def _packages(self): Line 62: self.packager.installUpdate(('ovirt-hosted-engine-ha',)) Line 63: self.packager.installUpdate(('ovirt-hosted-engine-setup',)) > what if only ha is updated? setup is requiring it but AFAIK installUpdate w the top level package that we grab should pull the minimum required dependencies. yum update should update misc updates. Line 64: Line 65: @plugin.event( Line 66: stage=plugin.Stages.STAGE_CLOSEUP, Line 67: ) Line 74: name=service, Line 75: state=self.environment[ Line 76: odeploycons.HostedEngineEnv.ENABLE Line 77: ], Line 78: ) the same note is here, all you need is the root service, that should depend on the other service, you can check this if services.supportsDependency(), only if not and the service does not start its dependencies for some reason you should do it here. once upgraded the %post should restart service if harmless and should be. so actually, all we need to do if service is well behaved (and as we control it it can be), to start and enable at boot the root service. Line 79: self.services.state( Line 80: name=service, Line 81: state=False, Line 82: ) -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
