Omer Frenkel has posted comments on this change.
Change subject: core: throw canDo if no space for stateless VM snapshots
(#852647)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 184: *
Line 185: * @param vm
Line 186: * @return true if all storage domains have enough space to
create snapshots for this VM plugged disks
Line 187: */
Line 188: private boolean hasSpaceForSnapthosts(VM vm) {
this method need to sum the disks per domain,
otherwise, if i have 1 domain and 5 disks, but space for only 1 snapshot,
the check will pass.
Line 189: for (Disk disk : getPluggedDisks(vm)) {
Line 190: if (disk.isAllowSnapshot()) {
Line 191: for (storage_domains domain :
getStorageDomainDAO().getAllStorageDomainsByImageId(((DiskImage)
disk).getImageId())) {
Line 192: if
(!StorageDomainSpaceChecker.hasSpaceForRequest(domain,
--
To view, visit http://gerrit.ovirt.org/7929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie15cce8ded9172f37be28fd8b3d7b299628ee43e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
