Yair Zaslavsky has posted comments on this change.
Change subject: core: throw canDo if no space for stateless VM snapshots
(#852647)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 189: */
Line 190: public boolean hasSpaceForSnapthosts(VM vm) {
Line 191: Map<storage_domains, Integer> map =
mapStorageDomainsToNumOfDisks(vm);
Line 192: Integer minSnapshotSize = Config.<Integer>
GetValue(ConfigValues.InitStorageSparseSizeInGB);
Line 193: for (storage_domains domain : map.keySet()) {
Please iterate using entrySet
Line 194: if (!StorageDomainSpaceChecker.hasSpaceForRequest(domain,
Line 195: minSnapshotSize * map.get(domain))) {
Line 196: log.error("not enough space to create snapshot on
domain " + domain.getId());
Line 197: return false;
--
To view, visit http://gerrit.ovirt.org/7929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie15cce8ded9172f37be28fd8b3d7b299628ee43e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
