Vered Volansky has posted comments on this change. Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/39004/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java: Line 53: } Line 54: Line 55: private void createDefaultFileStats(Object[] fileNames) { Line 56: for (int i = 0; i < fileNames.length; i++) { Line 57: fileStats.put((String) fileNames[i], null); > This is not correct, let's discuss f2f about it OK, I'm removing it so I can move forward with this and other patches. This looked redundant, but certainly not wrong (without the change), so there shouldn't be any harm in just returning it. Lets talk and if need be, I'll add a patch later on. Line 58: } Line 59: } Line 60: Line 61: public Map<String, Map<String, Object>> getFileStats() { -- To view, visit https://gerrit.ovirt.org/39004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
