Tal Nisan has posted comments on this change. Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/39004/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java: Line 54: } Line 55: Line 56: private void createDefaultFileStats(Object[] fileNames) { Line 57: for (int i = 0; i < fileNames.length; i++) { Line 58: fileStats.put((String) fileNames[i], Collections.<String, Object>emptyMap()); > Upon deeper inspection, this will fail in IsoDomainListSynchronizer line 60 What I mean is that for every file returned without a size (from old VDSMs) we'll get a logged exception, ISO with 50 files will log 50 exceptions and will trash the logs as well as look as something is not right Line 59: } Line 60: } Line 61: Line 62: public Map<String, Map<String, Object>> getFileStats() { -- To view, visit https://gerrit.ovirt.org/39004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
