Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/38547/17/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 98: ) Line 99: if self.environment[odeploycons.HostedEngineEnv.ENABLE]: > all this sequence should be done only if enable... we should not touch anyt so you suggest to use a different env for disabling the hosted engine support on the node? Something like odeploycons.HostedEngineEnv.ACTION enable / disable ? Line 100: self.services.state( Line 101: name=service, Line 102: state=True, Line 103: ) -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
