Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/38547/17/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 89: self.services.startup( Line 90: name=service, Line 91: state=self.environment[ Line 92: odeploycons.HostedEngineEnv.ENABLE Line 93: ], > this should be done only for root service, please notice that due to orderi if the init system doesn't support dependencies, how do you handle the start on reboot without this? Maybe not an issue since we're going to support hosted engine only on RHEL7 after all, so I'm fine with dropping the whole check on the dependency suppport and just take the root service. Line 94: ) Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 98: ) Line 99: if self.environment[odeploycons.HostedEngineEnv.ENABLE]: > oh, I did not know we are disabling anything, we do not disable any other s Leaving it running will cause the service to try to spawn the engine vm also if the user don't want to have the engine VM running on that host. We can go with ENABLE = None/True/False and set False only if the option was previously active on engine side. I would prefer to just disable the service if it exists and not enabled by the env key. Line 100: self.services.state( Line 101: name=service, Line 102: state=True, Line 103: ) -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
