Vinzenz Feenstra has posted comments on this change. Change subject: Allow to avoid lock screen on spice disconnect ......................................................................
Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/34079/15/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ConsoleDisconnectAction.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ConsoleDisconnectAction.java: Line 14: public static ConsoleDisconnectAction fromValue(String value) { Line 15: try { Line 16: return StringUtils.isEmpty(value) ? LOCK_SCREEN : valueOf(value.toUpperCase()); Line 17: } catch (IllegalArgumentException e) { Line 18: return null; > Consider sending a message to the log, something like this: Done Line 19: } Line 20: } https://gerrit.ovirt.org/#/c/34079/15/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1199: </xs:appinfo> Line 1200: </xs:annotation> Line 1201: </xs:element> Line 1202: </xs:sequence> Line 1203: </xs:complexType> > Before merging correct the indentation: 2 spaces per level. Done Line 1204: Line 1205: <xs:element name="selinux_modes" type="SELinuxModes" /> Line 1206: Line 1207: <xs:complexType name="SELinuxModes"> -- To view, visit https://gerrit.ovirt.org/34079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
