Martin Betak has posted comments on this change. Change subject: Allow to avoid lock screen on spice disconnect ......................................................................
Patch Set 16: (5 comments) https://gerrit.ovirt.org/#/c/34079/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 594: { Line 595: privateUsbPolicy = value; Line 596: } Line 597: Line 598: private NotChangableForVmInPoolListModel<ConsoleDisconnectAction> privateConsoleDisconnectAction; please don't use the 'private' prefix in new identifiers Line 599: Line 600: public ListModel<ConsoleDisconnectAction> getConsoleDisconnectAction() Line 601: { Line 602: return privateConsoleDisconnectAction; Line 596: } Line 597: Line 598: private NotChangableForVmInPoolListModel<ConsoleDisconnectAction> privateConsoleDisconnectAction; Line 599: Line 600: public ListModel<ConsoleDisconnectAction> getConsoleDisconnectAction() please put the opening '{' on same line Line 601: { Line 602: return privateConsoleDisconnectAction; Line 603: } Line 604: Line 605: setConsoleDisconnectAction same here https://gerrit.ovirt.org/#/c/34079/16/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java: Line 124: assertTrue(vm.getAutoConverge()); Line 125: assertTrue(vm.getMigrateCompressed()); Line 126: assertEquals(EMULATED_MACHINE, vm.getCustomEmulatedMachine()); Line 127: assertEquals(CUSTOM_CPU_NAME, vm.getCustomCpuName()); Line 128: assertEquals(vm.getConsoleDisconnectAction(), ConsoleDisconnectAction.REBOOT); in assertions, put the expected value first Line 129: } Line 130: Line 131: /** Line 132: * Verifies {@link org.ovirt.engine.ui.uicommonweb.builders.vm.CommonUnitToVmBaseBuilder} https://gerrit.ovirt.org/#/c/34079/16/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java: Line 140: assertTrue(model.getSpiceFileTransferEnabled().getEntity()); Line 141: assertTrue(model.getSpiceCopyPasteEnabled().getEntity()); Line 142: assertTrue(model.getAutoConverge().getSelectedItem()); Line 143: assertTrue(model.getMigrateCompressed().getSelectedItem()); Line 144: assertEquals(model.getConsoleDisconnectAction().getSelectedItem(), ConsoleDisconnectAction.LOCK_SCREEN); same here: please put expected value first Line 145: } Line 146: Line 147: /** Verifies {@link org.ovirt.engine.ui.uicommonweb.builders.vm.SerialNumberPolicyVmBaseToUnitBuilder} */ Line 148: protected void verifyBuiltSerialNumber(UnitVmModel model) { -- To view, visit https://gerrit.ovirt.org/34079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
