Sharad Mishra has posted comments on this change. Change subject: core: log stacktraces for failed VDSCommandBase calls ......................................................................
Patch Set 1: Looks good to me, but someone else must approve I agree with Federico that we should bubble up exceptions. But in this patch we are just logging the stacktrace. -- To view, visit http://gerrit.ovirt.org/8243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19d03f42a061531757daf870a6ac8eed34c2f992 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
