Allon Mureinik has posted comments on this change.
Change subject: core: log stacktraces for failed VDSCommandBase calls
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 112: }
Line 113:
Line 114: private void logException(RuntimeException ex) {
Line 115: log.errorFormat("Command {0} execution failed. Exception:
{1}", getCommandName(), ExceptionUtils.getMessage(ex));
Line 116: if (!(ex instanceof VDSExceptionBase)) {
I really don't like the user of instanceof.
Why not overload the method to recive VDSExceptionBase?
In both places this function is used, you already have that information.
Line 117: log.error(ExceptionUtils.getStackTrace(ex));
Line 118: }
Line 119: }
Line 120:
--
To view, visit http://gerrit.ovirt.org/8243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d03f42a061531757daf870a6ac8eed34c2f992
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
