Juan Hernandez has posted comments on this change.
Change subject: restapi: RSDL - report 'delete' on collections where exists
......................................................................
Patch Set 1:
This change produces two new link definitions in the generated RSDL:
<link href="clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks"
rel="delete">
<description>delete the bricks in the gluster volume attached to the
cluster</description>
<request>
<http_method>DELETE</http_method>
<headers>
<header required="false">
<name>Correlation-Id</name>
<value>any string</value>
</header>
<header required="true">
<name>Content-Type</name>
<value>application/xml|json</value>
</header>
</headers>
<body>
<parameters_set>
<description>delete bricks in the gluster volume attached to the
cluster</description>
<parameter required="true" type="collection">
<name>bricks</name>
<parameters_set>
<parameter required="true" type="xs:string">
<name>brick.id</name>
</parameter>
</parameters_set>
</parameter>
<parameter required="false" type="xs:unsignedShort">
<name>replica_count</name>
</parameter>
</parameters_set>
</body>
</request>
</link>
This first link is correctly documented, however is using a body for the DELETE
action, which is unusual. I think that we should avoid this usage of the DELETE
method. All the other DELETE methods that have a body use an "action" as the
body. I know that this wasn't introduced by this patch, but it may be worth to
replace this DELETE method with an action before documenting its existence.
The following link is also generated, and I think it isn't correctly
documented. Can you check why?
<link
href="datacenters/{datacenter:id}/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks"
rel="delete">
<request>
<http_method>DELETE</http_method>
<body/>
</request>
</link>
--
To view, visit https://gerrit.ovirt.org/40002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23461cb72df75766d1c09d2f9d979cfb0d8df38c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
