Allon Mureinik has uploaded a new change for review. Change subject: core: FB: ISingleAsyncOperationFactory naming (1) ......................................................................
core: FB: ISingleAsyncOperationFactory naming (1) Renamed the Initiazlize(ArrayList) method to initialize(ArrayList) in ISingleAsyncOperationFactory and its implementing classes, in order to solve the FindBugs warning about it (NM_METHOD_NAMING_CONVENTION). Change-Id: I87524bf25e8bc2b2289b6255caf384b03bcfc533 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 6 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/8393/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java index e283bd7..c9be7d9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java @@ -25,7 +25,7 @@ return _storagePool; } - public void Initialize(ArrayList parameters) { + public void initialize(ArrayList parameters) { if (!(parameters.get(0) instanceof ArrayList)) { throw new InvalidOperationException(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java index 5fe11a3..8f782df 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java @@ -14,8 +14,8 @@ } @Override - public void Initialize(java.util.ArrayList parameters) { - super.Initialize(parameters); + public void initialize(java.util.ArrayList parameters) { + super.initialize(parameters); if (!(parameters.get(3) instanceof Boolean)) { throw new InvalidOperationException(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java index bf545d8..70dcb03 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java @@ -9,8 +9,8 @@ private java.util.ArrayList<Guid> _vdsIdsToSetNonOperational; @Override - public void Initialize(ArrayList parameters) { - super.Initialize(parameters); + public void initialize(ArrayList parameters) { + super.initialize(parameters); if (!(parameters.get(3) instanceof java.util.ArrayList)) { throw new InvalidOperationException(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java index 0374b0e..b7851b8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java @@ -376,7 +376,7 @@ } @Override - public void Initialize(ArrayList parameters) { + public void initialize(ArrayList parameters) { // no need to initilalize params } }); diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java index 65d3a47..7dd9651 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java @@ -1,7 +1,7 @@ package org.ovirt.engine.core.utils; public interface ISingleAsyncOperationFactory { - void Initialize(java.util.ArrayList parameters); + void initialize(java.util.ArrayList parameters); ISingleAsyncOperation CreateSingleAsyncOperation(); } diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java index 6c6c58b..e9d3547 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java @@ -11,7 +11,7 @@ ISingleAsyncOperationFactory factory) { _numberOfOperations = numberOfOperations; _factory = factory; - _factory.Initialize(parameters); + _factory.initialize(parameters); } private class AsyncOpThread implements Runnable { -- To view, visit http://gerrit.ovirt.org/8393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87524bf25e8bc2b2289b6255caf384b03bcfc533 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
