Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Fix CDI in dal module to work with EAP/WildFly ......................................................................
Patch Set 3: That method could work but it requires annotating any possible injection point of DbEngineDialect (also those that currently we do not consider as a managed beans). Alternatively we could implement a veto mechanism (here is an example https://github.com/kwart/jboss-eap-quickstart/blob/master/cdi-veto/src/main/java/org/jboss/as/quickstart/cdi/veto/VetoExtension.java). I'm in favor of that solution as we'll need that for many purposes (e.g. vetoing JPA and REST entities). CDI 1.1 defines @Vetoed annotation, which I trying to mimic here. Although I prefer the last one, I wouldn't insist on that, you could choose which solution fits better (your current implementation is one of the options). -- To view, visit https://gerrit.ovirt.org/40151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I122b02f846cfbb9b861d13792790cf93ca7ee0d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
