Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
......................................................................
Patch Set 3:
> What about using @Named("configurableDbEngineDialect) on both ends (produces
> method and the injection point)?
> Like the following:
> @Produces
> @Singleton
> public JdbcTemplate produceJdbcTemplate(
> DataSource dataSource,
> @Named("configurableDbEngineDialect) DbEngineDialect
> dbEngineDialect,
> SQLExceptionTranslator sqlExceptionTranslator) {
> ...
> }
>
> @Produces
> @Singleton
> @Named("configurableDbEngineDialect)
> public DbEngineDialect produceDbEngineDialect() {
> ...
> }
Ah, I misunderstood your comment. I thought that we will need to use unique
name per db dialect
in @Named, but the above looks good. I will test it and if it will work I will
use it instead
a boolean constructor.
Thanks
--
To view, visit https://gerrit.ovirt.org/40151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I122b02f846cfbb9b861d13792790cf93ca7ee0d6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
