Michael Pasternak has posted comments on this change. Change subject: restapi: #854479 Attach Disk To VM - Return Disk In Response ......................................................................
Patch Set 3: Do not submit we in context of POST /api/vms/xxx/disks, i.e CREATE operation, so in case of: 1. creating disk returned disk 2. in case of attach returned response? this is inconsistent behaviour, the fact that we running action in case of attach behind the scene is only implementation detail, in sake of consistency should be returned disk in both cases. -- To view, visit http://gerrit.ovirt.org/8335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a50077886734f73842141262f5c338979dcae5c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
