Michael Pasternak has posted comments on this change.
Change subject: restapi: #854479 Attach Disk To VM - Return Disk In Response
......................................................................
Patch Set 3: No score
of course Response in signature of both methods, otherwise
we could not return anything to the client, it has to be
web.response,
the thing is when:
1. creating disk, returned Disk
2, when attaching disk, returned Action when you pass
action in signature, but it's not the case (i forgot that you've added [1] in
action).
[1]
if (action!=null) {
action.setStatus(StatusUtils.create(CreationStatus.COMPLETE));
return Response.ok().entity(action).build();
} else {
return Response.ok().build();
}
--
To view, visit http://gerrit.ovirt.org/8335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a50077886734f73842141262f5c338979dcae5c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
