Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: show tooltips on cropped input boxes ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39121/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java: Line 104: } Line 105: } Line 106: }, MouseDownEvent.getType()); Line 107: Line 108: Window.addResizeHandler(new ResizeHandler() { > When a GWT widget (its corresponding DOM element) gets detached from DOM, a Sorry, I messed up my previous comment. If some (dynamic DOM attach/detach) widget needs to use global handlers (e.g. Window.addResizeHandler) I think it's best to use: * Widget.onLoad() to register any handlers, executed immediately after widget's DOM element is attached to DOM * Widget.onUnload() to destroy any handlers, executed immediately before widget's DOM element is detached from DOM Line 109: @Override Line 110: public void onResize(ResizeEvent event) { Line 111: setTooltip(SafeHtmlUtils.fromString(getText())); Line 112: } -- To view, visit https://gerrit.ovirt.org/39121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6713b4aa624948477e295db0a95f24fbf251ca4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
