anmolbabu has posted comments on this change.

Change subject: engine: Georep status detail changes
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/40207/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java:

Line 1: package org.ovirt.engine.core.common.businessentities.gluster;
Line 2: 
Line 3: import java.io.Serializable;
Line 4: import java.util.Date;
Line 5: import java.util.Objects;
why not ObjectUtils? I Faced some conflict while cherry-picking some patch and 
I am afraid of having overriden those changes may be in a different patch. (I 
had conflicting usages of both ObjectUtils#equals and Objects#equals)
Line 6: 
Line 7: import org.ovirt.engine.core.compat.Guid;
Line 8: 
Line 9: public class GlusterGeoRepSessionDetails implements Serializable{


Line 21:     private Long metaOpsPending;
Line 22:     private Long entryOpsPending;
Line 23:     private Long failures;
Line 24:     private Date updatedAt;
Line 25:     private Date lastSyncedAt;
what is the difference between lastSyncedAt and updatedAt?

And if updatedAt is a field that indicates when engine synced last, where would 
we show it? I mean I am asking from status detail popup perspective :)
Line 26:     private Date checkPointTime;
Line 27:     private Date checkPointCompletedAt;
Line 28:     private boolean checkpointCompleted;
Line 29: 


https://gerrit.ovirt.org/#/c/40207/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java:

Line 22:     private static final String CHECK_POINT_COMPLETED = 
"checkpointCompleted";
Line 23:     private static final String CHECK_POINT_TIME = "checkpointTime";
Line 24: 
Line 25:     private final ArrayList<GlusterGeoRepSessionDetails> geoRepDetails 
= new ArrayList<GlusterGeoRepSessionDetails>();
Line 26:     private final List<GlusterGeoRepSession> geoRepSessions = new 
ArrayList<GlusterGeoRepSession>();
Why is this field required? Honestly speaking I tried to remove it as this 
field is not being fed with any values locally and it is a private field, but 
to my surprise I got into troubles after removing it I don't remember the issue 
I (I faced after removing this field) exactly and wanted to understand its 
significance with your help and may be its the right time now before I forget 
again.
Line 27: 
Line 28:     private Long parseSafeLong(Map<String, Object> innerMap, String 
key) {
Line 29:         return innerMap.containsKey(key) && 
StringUtils.isNumeric(innerMap.get(key).toString()) ? 
Long.parseLong(innerMap.get(key).toString())
Line 30:                 : null;


https://gerrit.ovirt.org/#/c/40207/2/packaging/dbscripts/upgrade/03_06_1300_alter_georep_session_details.sql
File packaging/dbscripts/upgrade/03_06_1300_alter_georep_session_details.sql:

Line 10: select fn_db_add_column('gluster_georep_session_details', 'failures', 
'BIGINT NULL');
Line 11: select fn_db_add_column('gluster_georep_session_details', 
'last_synced_at', 'TIMESTAMP WITH TIME ZONE NULL');
Line 12: select fn_db_add_column('gluster_georep_session_details', 
'checkpoint_time', 'TIMESTAMP WITH TIME ZONE NULL');
Line 13: select fn_db_add_column('gluster_georep_session_details', 
'checkpoint_completed_time', 'TIMESTAMP WITH TIME ZONE NULL');
Line 14: select fn_db_add_column('gluster_georep_session_details', 
'is_checkpoint_completed', 'BOOLEAN DEFAULT FALSE');
Again a UI perspective question :)
Is this field required only required to control visibility/availability of 
checkpoint_completed_time. If yes, is it not possibile to decide the same on 
the null/not null value of checkpoint_completed_time ?
Line 15: 


-- 
To view, visit https://gerrit.ovirt.org/40207
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id05fa1d8537bcd3a0a80f1765f142dab575f43ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to