Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: using cloud-init to run engine-setup ......................................................................
Patch Set 16: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/40546/16/src/ovirt_hosted_engine_setup/appliance_esetup.py File src/ovirt_hosted_engine_setup/appliance_esetup.py: Line 83: raise RuntimeError(error_msg) Line 84: Line 85: self.logger.debug('Successfully connected to the appliance') Line 86: Line 87: def _appliance_readline_nb(self, timeout=5): Maybe better to use a constant here Line 88: """ Line 89: Read a line from the (already-connected) appliance in a not blocking Line 90: way. The response is non-newline-terminated string plus a boolean Line 91: to indicate that a timeout has occurred. Line 110: if r == '\n': Line 111: return line, False Line 112: line += r Line 113: len += 1 Line 114: if len >= 200: Maybe better to use a constant here. Line 115: return line, False Line 116: else: Line 117: return line, True Line 118: -- To view, visit https://gerrit.ovirt.org/40546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I305232fc44a524fd53e2d7fbd819ab5b95d4931c Gerrit-PatchSet: 16 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
