Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: using cloud-init to run engine-setup ......................................................................
Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/40546/18/src/ovirt_hosted_engine_setup/appliance_esetup.py File src/ovirt_hosted_engine_setup/appliance_esetup.py: Line 31: return gettext.dgettext(message=m, domain='ovirt-hosted-engine-setup') Line 32: Line 33: Line 34: DEFAULTREADLINETIMEOUT = 5 Line 35: MAXLINELENGTH = 1024 Can you add some '_'? A bit hard to read... Line 36: Line 37: Line 38: class ApplianceEngineSetup(object): Line 39: -- To view, visit https://gerrit.ovirt.org/40546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I305232fc44a524fd53e2d7fbd819ab5b95d4931c Gerrit-PatchSet: 18 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
