Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: automatically shutdown engine VM on automated setup ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40802/1/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 755: ) Line 756: def CONSOLE_TYPE(self): Line 757: return 'OVEHOSTED_VDSM/consoleType' Line 758: Line 759: AUTOMATE_VM_SHUTDOWN = 'OVEHOSTED_VM/automateVMShutdown' Perhaps add a question in code, "summary=True", "answerfile=True" Line 760: Line 761: Line 762: @util.export Line 763: @util.codegen https://gerrit.ovirt.org/#/c/40802/1/src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py File src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py: Line 104: if not self.environment[ohostedcons.CoreEnv.IS_ADDITIONAL_HOST]: Line 105: Line 106: if self.environment[ Line 107: ohostedcons.VMEnv.AUTOMATE_VM_SHUTDOWN Line 108: ] is None: I'd add a question for this in cloud_init.py. I can imagine a user wanting automatic run of engine-setup and still like to check if all looks ok. If you disagree, perhaps put this code there, in customization, so it's visible early in log file (and in PREVIEW if you add there too). Line 109: self.environment[ Line 110: ohostedcons.VMEnv.AUTOMATE_VM_SHUTDOWN Line 111: ] = self.environment[ Line 112: ohostedcons.VMEnv.CLOUD_INIT_EXECUTE_ESETUP -- To view, visit https://gerrit.ovirt.org/40802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6417a76302f71fc47bfc84c20aef9203ec4f1548 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
