Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: automatically shutdown engine VM on automated setup ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40802/2/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 758: Line 759: @ohostedattrs( Line 760: answerfile=True, Line 761: summary=True, Line 762: description=_('Automatically restart as a monitored service'), > Perhaps 'Reboot engine VM after setup'? It's not just a simple optional reboot: it's going to start in a different manner and you really have to in onder to have HA Line 763: ) Line 764: def AUTOMATE_VM_SHUTDOWN(self): Line 765: return 'OVEHOSTED_VM/automateVMShutdown' Line 766: https://gerrit.ovirt.org/#/c/40802/2/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 233: ] = self.dialog.queryString( Line 234: name='AUTOMATE_VM_SHUTDOWN', Line 235: note=_( Line 236: 'Automatically restart the engine VM ' Line 237: 'as a monitored service when done ' > s/when done/after engine-setup Done Line 238: '(@VALUES@)[@DEFAULT@]? ' Line 239: ), Line 240: prompt=True, Line 241: validValues=(_('Yes'), _('No')), -- To view, visit https://gerrit.ovirt.org/40802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6417a76302f71fc47bfc84c20aef9203ec4f1548 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
