Moti Asayag has uploaded a new change for review. Change subject: engine: Use typed empty list in extensions ......................................................................
engine: Use typed empty list in extensions Change-Id: I481e29be6155bbcf5c53213dca172613e4c6dfe9 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java 2 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/40931/1 diff --git a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java index 206a050..d7bcd78 100644 --- a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java +++ b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java @@ -8,11 +8,10 @@ import java.util.Properties; import org.apache.commons.lang.StringUtils; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - import org.ovirt.engine.extensions.aaa.builtin.kerberosldap.serverordering.LdapServersOrderingAlgorithmFactory; import org.ovirt.engine.extensions.aaa.builtin.kerberosldap.utils.ldap.LdapProviderType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class DirectorySearcher { @@ -46,7 +45,7 @@ List<?> returnValue = find(ldapQueryData, 0); if (returnValue == null) { - returnValue = Collections.EMPTY_LIST; + returnValue = Collections.emptyList(); } return returnValue; } diff --git a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java index d399aec..d0ceee6 100644 --- a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java +++ b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java @@ -7,7 +7,7 @@ * Contains search result information for directory groups. */ public class GroupSearchResult { - private List<String> memberOf = (List<String>) Collections.EMPTY_LIST; + private List<String> memberOf = Collections.<String> emptyList(); private String distinguishedName; private String id; -- To view, visit https://gerrit.ovirt.org/40931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I481e29be6155bbcf5c53213dca172613e4c6dfe9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
