Omer Frenkel has posted comments on this change. Change subject: engine: Use typed empty list in extensions ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/40931/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java: Line 6: /** Line 7: * Contains search result information for directory groups. Line 8: */ Line 9: public class GroupSearchResult { Line 10: private List<String> memberOf = Collections.<String> emptyList(); you could remove the <String> here as well Line 11: private String distinguishedName; Line 12: private String id; Line 13: Line 14: public GroupSearchResult(LdapGroup group) { -- To view, visit https://gerrit.ovirt.org/40931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I481e29be6155bbcf5c53213dca172613e4c6dfe9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
